Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TODOs from Doc #61

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Remove TODOs from Doc #61

merged 3 commits into from
Mar 13, 2024

Conversation

FriedrichRober
Copy link
Collaborator

Closes #53

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Merging #61 (8c7ba51) into master (3c1708e) will not change coverage.
The diff coverage is n/a.

❗ Current head 8c7ba51 differs from pull request most recent head 7fca603. Consider uploading reports for the commit 7fca603 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files          12       12           
  Lines        1608     1608           
=======================================
  Hits         1519     1519           
  Misses         89       89           

doc/intro.xml Outdated Show resolved Hide resolved
@fingolfin
Copy link
Member

The error here is really weird, and I cannot reproduce it locally:

Generating documentation in Directory("/home/runner/work/LINS/LINS/doc/")
#I Composing XML document . . .
#I Parsing XML document . . .
#I Checking XML structure . . .
#I Text version (also produces labels for hyperlinks):
#I First run, collecting cross references, index, toc, bib and so on . . .
#I Table of contents complete.
#I Producing the index . . .
Error, Record Element: '<rec>.bibentries' must have an assigned value in
#I Writing bibliography . . .
  need := List( r.bibentries, function ( a )
        return RecBibXMLEntry( a, "Text", r.bibstrings );
    end ); at /home/runner/gap/pkg/gapdoc/lib/GAPDoc2Text.gi:597 called from 

@fingolfin fingolfin merged commit afa44bb into master Mar 13, 2024
3 checks passed
@fingolfin fingolfin deleted the fr/docTODO branch March 13, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve TODOs in the documentation
2 participants